PM DEVICE RUNTIME: Ifdef out unused events if PM_DEVICE_RUNTIME_ASYNC=n #93727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjarki-andreasen
changed the title
bjarki-andreasen
changed the title
The k_event event is only used if CONFIG_PM_DEVICE_RUNTIME_ASYNC is selected, but EVENTS is selected, and the k_event included in the struct pm_device if CONFIG_PM_DEVICE_RUNTIME is selected. Correct to only include event and EVENTS if CONFIG_PM_DEVICE_RUNTIME_ASYNC is selected. This saves us 1 struct event per PM DEVICE. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
bjarki-andreasen
force-pushed
the
pm-device-runtime-fix-event-select
branch
from
836e6ef to
24445eb
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
struct k_event eventis only used ifCONFIG_PM_DEVICE_RUNTIME_ASYNCis selected, butEVENTSis selected, and thestruct k_eventincluded in thestruct pm_device_baseifCONFIG_PM_DEVICE_RUNTIMEis selected.Correct to only include event and EVENTS if
CONFIG_PM_DEVICE_RUNTIME_ASYNCis selected.